Fix tab+enter regression on slash commands #4639
Merged
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+907
to
+910
| && rest.is_empty() | ||
| && let Some((_n, cmd)) = built_in_slash_commands() | ||
| .into_iter() | ||
| .find(|(n, _)| *n == name) |
There was a problem hiding this comment.
i feel like '/foo ...' should give an error if it doesn't exist...? rather than sending it to the model.
There was a problem hiding this comment.
Yes, agreed. For now this fixes the regression but can add that later.
nornagon-openai
approved these changes
Oct 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when you would enter
/di, hit tab on/diff, and then hit enter, it would execute/diff. But now it's just sending it as a text. This fixes the issue.