8000 software: store relative paths for masks in MVS scene and fix global space IDs · Pull Request #2193 · openMVG/openMVG · GitHub
[go: up one dir, main page]

Skip to content

software: store relative paths for masks in MVS scene and fix global space IDs#2193

Merged
pmoulon merged 6 commits intodevelopfrom
unknown repository
Nov 1, 2023
Merged

software: store relative paths for masks in MVS scene and fix global space IDs#2193
pmoulon merged 6 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link
@ghost ghost commented Apr 27, 2023

image

@ghost ghost changed the title software: store relative paths for masks in MVS scene software: store relative paths for masks in MVS scene and fix global space IDs Jul 28, 2023
@csparker247
Copy link
Contributor

It's been awhile, so I'm just bumping this. @pmoulon (or some other maintainer) can we get this reviewed and merged? This fixes some issues I'm having with masks and OpenMVS.

@ghost
Copy link
Author
ghost commented Oct 26, 2023

@Sanheiii I am planning on removing global IDs, are you using global IDs for anything?

@Sanheiii
Copy link
Contributor

It's been a long time since my last commit, I don't remember the details of it, you can check the code to decide if you want to remove it or not.

@ghost
Copy link
Author
ghost commented Oct 27, 2023
{
  "name": "images\\DSC09972.JPG",
  "mask_name": "images\\DSC09972.mask.png",
  "platform_id": 0,
  "camera_id": 0,
  "pose_id": 27,
  "id": 27
},
{
  "name": "images\\DSC09973.JPG",
  "mask_name": "images\\DSC09973.mask.png",
  "platform_id": 1,
  "camera_id": 0,
  "pose_id": 0,
  "id": 28
}

@pmoulon good to go chef.

std::vector<ViewScore> viewScores; // list of view scores for this image (optional)

Image() : platformID(NO_ID), cameraID(NO_ID), poseID(NO_ID), ID(NO_ID) {}
Image() : platformID(NO_ID), cameraID(NO_ID), poseID(NO_ID), ID(NO_ID), minDepth(0), avgDepth(0), maxDepth(0) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4CJ7T I see more information here than what exists in https://github.com/cdcseacave/openMVS/blob/master/libs/MVS/Interface.h#L524 is it normal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the latest interface.h from the develop branch.

Copy link
Author
@ghost ghost Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is compatible with the main branch of OpenMVS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmoulon
Copy link
Member
pmoulon commented Oct 27, 2023

@4CJ7T Please let me know why this #2193 (comment) does not match OpenMVS repo

@pmoulon
Copy link
Member
pmoulon commented Nov 1, 2023

Thank you

@pmoulon pmoulon merged commit 42b6b40 into openMVG:develop Nov 1, 2023
TongZhe2016 pushed a commit to TongZhe2016/openMVG that referenced this pull request Apr 24, 2025
… and fix global space IDs (openMVG#2193)

* Update main_openMVG2openMVS.cpp

* Update InterfaceMVS.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0