Prefer CMake Config when looking for Flann#2147
Merged
pmoulon merged 1 commit intoopenMVG:developfrom Feb 2, 2023
StefanBruens:prefer_flann_config
Merged
Prefer CMake Config when looking for Flann#2147pmoulon merged 1 commit intoopenMVG:developfrom StefanBruens:prefer_flann_config
pmoulon merged 1 commit intoopenMVG:developfrom
StefanBruens:prefer_flann_config
Conversation
Latest flann may link to e.g. liblz4, and the FindFlann module does not handle transitive lib dependencies. In case external flann is required try the upstream CMake Config first, and fall back to the legacy lookup. Fixes #1265.
Member
|
Thank you for your PR @StefanBruens. |
Member
|
@StefanBruens Thx you for your contribution. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest flann may link to e.g. liblz4, and the FindFlann module does not handle transitive lib dependencies.
In case external flann is required try the upstream CMake Config first, and fall back to the legacy lookup.
Fixes #1265.