Update to semconv 1.34.0 #217
Conversation
semconv/src/main/java/io/opentelemetry/semconv/DbAttributes.java
Outdated
Show resolved
Hide resolved
|
this is looking better... |
|
more javadoc formatting work ahead:
|
...v-incubating/src/main/java/io/opentelemetry/semconv/incubating/HttpIncubatingAttributes.java
Show resolved
Hide resolved
| * | ||
| * <p>For sanitization see <a | ||
| * href="../database/database-spans.md#sanitization-of-dbquerytext">Sanitization of {@code | ||
| * href="/docs/database/database-spans.md#sanitization-of-dbquerytext">Sanitization of {@code |
There was a problem hiding this comment.
@open-telemetry/weaver-maintainers @lmolkova what do you think of having weaver automatically turn this into a fully-qualified link, e.g.
| {% for attribute in ctx.attributes | select("enum") | rejectattr("name", "in", ctx.excluded_attributes) %} | ||
| {%- if attribute is stable -%} | ||
| {% for attribute in ctx.attributes | select("enum") | rejectattr("name", "in", ctx.excluded_attributes) %} | ||
| {% set enum_deprecated_in_favor_of_stable = namespace(value=false) %} |
There was a problem hiding this comment.
What does the namespace function do?
There was a problem hiding this comment.
it creates something like an object with a nested attribute value, which can then be updated inside of an inner block
think of this code like AtomicBoolean being passed into methods (in this case into a nested if) so you can update the value in the method and then get updated value after the method call
| {%- endif -%} | ||
| {%- endif -%} | ||
| {%- endfor %} | ||
| {%- if enum_deprecated_in_favor_of_stable.value -%} |
There was a problem hiding this comment.
Can you summarize what this change is doing?
There was a problem hiding this comment.
when writing incubating model, deprecate the enum class if the attribute has been stabilized and it has no values which are still experimental (other than those which may be deprecated explicitly)
(this is to deal with the db system name mixed status where only some values are stabilized
luckily not more javadoc formatting work... |
No description provided.