-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[demo] Update Shipping service docs #7062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] Update Shipping service docs #7062
Conversation
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass copy edits. Thanks for taking this on, @julianocosta89!
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Thank you for the review @tiffany76 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a copy edit perspective!
@open-telemetry/demo-approvers, would anyone else like to give this a look? The page previews are linked in the PR description. Thanks!
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
PR open-telemetry/opentelemetry-demo#2214 brought a big refactor on the Shipping service, where the service was refactored to use Actix-Web, a Rust web framework that has an instrumentation library.
With that change we also added Metrics and Logs to the service, so now the doc page can be complete.
I've also added a couple of missing services on the telemetry features coverage.
This will need to be updated accordingly, but at least now we have all services listed, and Rust up-to-date on those tables.
Lastly, as Actix-Web doesn't support gRPC, the architecture was also updated.
PREVIEWS: