E544 [demo] Update Shipping service docs by julianocosta89 · Pull Request #7062 · open-telemetry/opentelemetry.io · GitHub
[go: up one dir, main page]

Skip to content

Conversation

julianocosta89
Copy link
Member
@julianocosta89 julianocosta89 commented Jun 6, 2025

PR open-telemetry/opentelemetry-demo#2214 brought a big refactor on the Shipping service, where the service was refactored to use Actix-Web, a Rust web framework that has an instrumentation library.

With that change we also added Metrics and Logs to the service, so now the doc page can be complete.

I've also added a couple of missing services on the telemetry features coverage.
This will need to be updated accordingly, but at least now we have all services listed, and Rust up-to-date on those tables.

Lastly, as Actix-Web doesn't support gRPC, the architecture was also updated.


PREVIEWS:

@julianocosta89 julianocosta89 requested a review from a team as a code owner June 6, 2025 11:44
@opentelemetrybot opentelemetrybot requested a review from a team June 6, 2025 11:44
julianocosta89 and others added 2 commits June 6, 2025 16:16
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link
Member
@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass copy edits. Thanks for taking this on, @julianocosta89!

julianocosta89 and others added 3 commits June 7, 2025 06:57
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@julianocosta89
Copy link
Member Author

Thank you for the review @tiffany76 🤩

Copy link
Member
@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a copy edit perspective!

@open-telemetry/demo-approvers, would anyone else like to give this a look? The page previews are linked in the PR description. Thanks!

@svrnm svrnm added this pull request to the merge queue Jun 10, 2025
Merged via the queue into open-telemetry:main with commit f92688f Jun 10, 2025
19 checks passed
tiffany76 added a commit to BeverlyJaneJ/opentelemetry.io that referenced this pull request Jun 18, 2025
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0