-
Notifications
You must be signed in to change notification settings - Fork 933
Move experimental sampling specification into OTEPs #4673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmacd
wants to merge
12
commits into
open-telemetry:main
Choose a base branch
from
jmacd:jmacd/deprecate_experimental_sampler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move experimental sampling specification into OTEPs #4673
jmacd
wants to merge
12
commits into
open-telemetry:main
from
jmacd:jmacd/deprecate_experimental_sampler
+30
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PeterF778 FYI |
carlosalberto
approved these changes
Oct 6, 2025
LGTM although not sure using the PR number feels good as this is a "old reference" document, rather than an actual OTEP. |
PeterF778
approved these changes
Oct 6, 2025
jsuereth
approved these changes
Oct 9, 2025
…cd/opentelemetry-specification into jmacd/deprecate_experimental_sampler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to improve our public documentation, which has two documents with the same title today, the second one being correct.
Finishes the deprecation process started in #4168.
When #4166 added the new sampling specification, the old one was renamed.
Now that the new specification is complete in the specification, the old one is a distraction.
Changes
This moves the old document into the
oteps/
repository where it will remain a permanent record of this effort.