[EndGoal] [DoNotMerge] Extend the set of attribute value types #4636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
commented
Aug 26, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit c17aec6.
10000
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR extends the OpenTelemetry attribute value types by replacing limited "standard attributes" with a more comprehensive "attribute" definition that supports complex values. The changes align with OTEP 4485 and related specifications to support arrays, maps, byte arrays, and empty values in addition to primitive types.
- Replaces references to "standard attribute" with "attribute" throughout the specification
- Updates attribute type definitions to use AnyValue instead of restricted primitive types
- Consolidates attribute value type definitions by removing duplicate type definitions from logs data model
- Updates attribute limits to handle complex value types including recursive application to nested structures
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specification/common/README.md | Major restructuring to define AnyValue and comprehensive attribute types, consolidating previously scattered definitions |
| specification/logs/data-model.md | Removes duplicate type definitions and updates references to use centralized AnyValue definition |
| specification/logs/api.md | Removes outdated status section about standard attribute conversion |
| specification/resource/data-model.md | Updates attribute type references from "standard attribute value" to "attribute value" |
| specification/resource/sdk.md | Updates documentation link text from "standard attributes" to "attributes" |
| specification/entities/data-model.md | Updates entity field types to use general attribute definition instead of restricted types |
| specification/common/attribute-type-mapping.md | Adds empty value conversion rules for AnyValue |
| oteps/entities/0256-entities-data-model.md | Updates broken internal links to use versioned external links |
| oteps/4485-extending-attributes-to-support-complex-values.md | Fixes broken internal link reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Sep 8, 2025
Open
Open
Closed
pellared
commented
Sep 8, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jsuereth
reviewed
Sep 17, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related proto PR: open-telemetry/opentelemetry-proto#707
Towards #4602
Towards #4487
Follows #4614
See Copilot's description: #4636 (review)
https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#how describes how languages should add support for new attribute value types.
This also proposes minimal changes for the attribute limits: https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#attribute-limits.