-
Notifications
You must be signed in to change notification settings - Fork 933
[spec] add environment variables as context propagators specification #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have a comment https://github.com/open-telemetry/opentelemetry-specification/pull/4454/files#r2015053822 which can be covered in a follow up PR.
### Context - Add context propagation through Environment Variables specification. ([#4454](#4454)) - On Propagators API, stabilize `GetAll` on the `TextMap` Extract. ([#4472](#4472)) ### Traces - Define sampling threshold field in OpenTelemetry TraceState; define the behavior of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2 randomness. ([#4166](#4166)) ### Metrics - Clarify SDK behavior for Instrument Advisory Parameter. ([#4389](#4389)) ### Logs - Add `Enabled` opt-in operation to the `LogRecordProcessor`. ([#4439](#4439)) - Stabilize `Logger.Enabled`. ([#4463](#4463)) - Stabilize `EventName`. ([#4475](#4475)) ### Baggage - Add context (baggage) propagation through Environment Variables specification. ([#4454](#4454)) ### Resource - Add Datamodel for Entities. ([#4442](#4442)) ### SDK Configuration - Convert declarative config env var substitution syntax to ABNF. ([#4448](#4448)) - List declarative config supported SDK extension plugin interfaces. ([#4452](#4452)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
With this it should be possible to keep track of performance issues also when called from wrapper tools. This tries to adhere to the environment specification laid out in open-telemetry/opentelemetry-specification#4454
* feat: Add OpenTelemetry tracing support With this it should be possible to keep track of performance issues also when called from wrapper tools. This tries to adhere to the environment specification laid out in open-telemetry/opentelemetry-specification#4454 * Add spans to core paths * Add docs * Remove too noisy span on jsonnet.Evaluate * Remove spans on the loader level to reduce noise * Reduce noise further * Improve consistency
Fixes #4323 #740
Changes
Add the specification for context and baggage propagation using environment variables as context propagators.
CHANGELOG.md
file updated for non-trivial changes