8000 feat(sidekiq): scheduled jobs improvements - `scheduled` operation and add links by smoke · Pull Request #1717 · open-telemetry/opentelemetry-ruby-contrib · GitHub
[go: up one dir, main page]
Skip to content

feat(sidekiq): scheduled jobs improvements - scheduled operation and add links #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(sidekiq): scheduled jobs improvements - scheduled operation and add links #1717

wants to merge 7 commits into from
+20 −6

Conversation

smoke
Copy link
Contributor
@smoke smoke commented Oct 6, 2025

When a Job is pushed via perform_in or friends, it goes through the following life-cycle:

  1. First the Job is pushed with at attribute in Redis from Sidekiq::Client - this will now create <...> scheduled span (before it was <...> publish
  2. Then the Job is handled from Sidekiq::Scheduled#enqueue and pushed without at attribute in Redis from Sidekiq::Client - this will keep creating <...> publish span
  3. Then the Job is handled by the Worker as usual

Additionally when using :propagation_style = :link and :trace_poller_enqueue = true a handy set of links are added between the 3 actors above.

@smoke smoke marked this pull request as draft October 6, 2025 13:41
@smoke smoke force-pushed the feat/sidekiq-links-to-scheduled-jobs branch 4 times, most recently from 03a5fdb to 4eca039 Compare October 6, 2025 13:57
@smoke smoke closed this Oct 6, 2025
@smoke smoke reopened this Oct 8, 2025
@smoke smoke marked this pull request as ready for review October 8, 2025 13:51
smoke added 3 commits October 8, 2025 16:52
@smoke
feat(sidekiq): scheduled jobs improvements - scheduled operation an…
bfb7c63 
…d add links

When a Job is pushed via `perform_in` or friends, it goes through the following life-cycle:
1. First the Job is pushed with `at` attribute in Redis from `Sidekiq::Client` - this will now create `<...> scheduled` span (before it was `<...> publish`
2. Then the Job is handled from `Sidekiq::Scheduled#enqueue` and pushed without `at` attribute in Redis from `Sidekiq::Client` - this will keep creating `<...> publish` span
3. Then the Job is handled by the Worker as usual

Additionally when using `:propagation_style = :link` and `:trace_poller_enqueue = true` a handy set of links are added between the 3 actors above.
@smoke
fix: use enqueued_at for enqueued_at
dc00407 
broken with open-telemetry#1444
@smoke
fix: tests work with empty array of links
6a3983f
@smoke smoke force-pushed the feat/sidekiq-links-to-scheduled-jobs branch from 44cda99 to 6a3983f Compare October 8, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smoke
0