10BC0 feat(otlp-transformer): add is_remote_parent span flags to OTLP exported Spans and SpanLinks by nikhilmantri0902 · Pull Request #5910 · open-telemetry/opentelemetry-js · GitHub
[go: up one dir, main page]
Skip to content

feat(otlp-transformer): add is_remote_parent span flags to OTLP exported Spans and SpanLinks #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2025
Merged

feat(otlp-transformer): add is_remote_parent span flags to OTLP exported Spans and SpanLinks #5910

merged 8 commits into from
Sep 22, 2025

Conversation

nikhilmantri0902
Copy link
Contributor
@nikhilmantri0902 nikhilmantri0902 commented Sep 5, 2025 •
edited
Loading

Which problem is this PR solving?

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes #5909

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit tests

Added unit tests for buildSpanFlags

cd experimental/packages/otlp-transformer
npm run compile

  • npm test -- --grep "span flags"

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@nikhilmantri0902 nikhilmantri0902 requested a review from a team as a code owner September 5, 2025 04:40
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Sep 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@nikhilmantri0902 nikhilmantri0902 changed the title fixed the isremote exporter flag passing Add is_remote_parent span flags to OTLP exported Spans and SpanLinks Sep 5, 2025
@nikhilmantri0902 nikhilmantri0902 mentioned this pull request Sep 5, 2025
Closed
@nikhilmantri0902
Copy link
Contributor Author

Shipping this feature will greatly help our product (signoz) in identifying and validating entrypoint spans.

pichlermarc
pichlermarc requested changes Sep 12, 2025
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Sep 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (b903af5) to head (7a1b9c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5910   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         315      315           
  Lines        8218     8225    +7     
  Branches     1665     1666    +1     
=======================================
+ Hits         7809     7816    +7     
  Misses        409      409
Files with missing lines Coverage Δ
...kages/otlp-transformer/src/trace/internal-types.ts 100.00% <ø> (ø)
...al/packages/otlp-transformer/src/trace/internal.ts 98.59% <100.00%> (+0.15%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc changed the title Add is_remote_parent span flags to OTLP exported Spans and SpanLinks feat(otlp-transformer): add is_remote_parent span flags to OTLP exported Spans and SpanLinks Sep 22, 2025
pichlermarc
pichlermarc reviewed Sep 22, 2025
View reviewed changes
Copy link
Member
@pichlermarc pichlermarc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes 🙂
One more thing then this PR is ready to merge (see comment).

Edit: also please run npm run lint:fix and commit the changes to address the linting errors :)

pichlermarc
pichlermarc reviewed Sep 22, 2025
View reviewed changes
@nikhilmantri0902
Copy link
Contributor Author

@pichlermarc thank you for your review and guidance. I have now made changes based on all comments and also addressed the linting fix. Let me know if we can merge this now, thank you!

< C5BA div class="AvatarStack-body" > @pichlermarc
Merge branch 'main' into fix/exporter_is_remote_flag
7a1b9c9
@pichlermarc pichlermarc added this pull request to the merge queue Sep 22, 2025
Merged via the queue into open-telemetry:main with commit 65c71f6 Sep 22, 2025
25 checks passed
@otelbot otelbot
Copy link
Contributor
otelbot bot commented Sep 22, 2025

Thank you for your contribution @nikhilmantri0902! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

This was referenced Oct 1, 2025
Open
Open
@otelbot-js otelbot-js bot mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add is_remote_parent span flags to OTLP exported Spans and SpanLinks
2 participants
@nikhilmantri0902 @pichlermarc
0