refactor(instrumentation-grpc): use relative path for semconv #5884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c368916 to
0bf9f03
Compare
4bdec4a to
a94296a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 307 307
Lines 8031 8031
Branches 1627 1627
=======================================
Hits 7635 7635
Misses 396 396
🚀 New features to boost your workflow:
|
pichlermarc
reviewed
Aug 28, 2025
a94296a to
223e4d8
Compare
pichlermarc
approved these changes
Aug 29, 2025
|
thanks! 🙂 |
|
Thank you for your contribution @overbalance! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This was referenced Sep 2, 2025
6 tasks
This was referenced Sep 4, 2025
Merged
Joozty
pushed a commit
to Joozty/opentelemetry-js
that referenced
this pull request
Sep 9, 2025
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Sep 9, 2025
The Contributor Experience group created a survey to help understand challenges and feedback from new contributors. We have this survey running for a few months on opentelemetry.io and the JS repo, with helpful feedback, so now adding to more repos. Example of message: open-telemetry/opentelemetry-js#5884 (comment) --------- Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
atoulme
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Sep 17, 2025
The Contributor Experience group created a survey to help understand challenges and feedback from new contributors. We have this survey running for a few months on opentelemetry.io and the JS repo, with helpful feedback, so now adding to more repos. Example of message: open-telemetry/opentelemetry-js#5884 (comment) --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the path to semconv.js in
@opentelemetry/instrumentation-grpcShort description of the changes
Update the path from
../src/semconv->./semconvType of change
How Has This Been Tested?
Compile the package and observe the correct path in the build folder:
../src/semconv->./semconvChecklist: