feat(opentelemetry-configuration): creation of basic FileConfigProvider #5863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5863 +/- ##
==========================================
+ Coverage 95.03% 95.04% +0.01%
==========================================
Files 306 307 +1
Lines 7969 7987 +18
Branches 1611 1614 +3
==========================================
+ Hits 7573 7591 +18
Misses 396 396
🚀 New features to boost your workflow:
|
pichlermarc
approved these changes
Aug 20, 2025
| createConfigProvider(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
nit: I think it could be beneficial to also add some tests for OTEL_EXPERIMENTAL_CONFIG_FILE
- unset
- empty string
- all whitespace
(should all not throw, looking at the code all cases are handled correctly right now already 🙂)
There was a problem hiding this comment.
the unset case is already tested, since it what the cases the use env variables do, but good point on adding for the other two, let me do that :)
This was referenced Sep 2, 2025
Joozty
pushed a commit
to Joozty/opentelemetry-js
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #5814
This PR creates the structure for a FileConfigProvider. In this PR it only checks if the file exists and is a YAML, returning an error otherwise.
Parse of the file will be done on a following PR