8000 chore: enable tsconfig isolatedModules by legendecas · Pull Request #5697 · open-telemetry/opentelemetry-js · GitHub
[go: up one dir, main page]
Skip to content

chore: enable tsconfig isolatedModules #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

chore: enable tsconfig isolatedModules #5697

merged 1 commit into from
May 21, 2025

Conversation

legendecas
Copy link
Member
@legendecas legendecas commented May 19, 2025 •
edited
Loading

Which problem is this PR solving?

Enables isolatedModules in tsconfig.base.json

Refs: #5691

Short description of the changes

No runtime side-effects are expected. This PR marks all type re-exports as export type.

Type of change

Please delete options that are not relevant.

  • Internal change.

How Has This Been Tested?

  • npm run compile passed

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas requested a review from a team as a code owner May 19, 2025 12:14
@codecov Codecov
Copy link
codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (9dbd1e4) to head (b15c6ac).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5697   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         310      310           
  Lines        7992     7998    +6     
  Branches     1614     1615    +1     
=======================================
+ Hits         7595     7601    +6     
  Misses        397      397
Files with missing lines Coverage Δ
api/src/experimental/index.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/aggregator/index.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/exemplar/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm trentm mentioned this pull request May 20, 2025
Closed
4 tasks
trentm
trentm approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@david-luna
Copy link
Contributor

I think this is a good addition in order to start with #4744
It would be nice to have it in contrib as well. I might create a PR this week :)

@david-luna david-luna added this pull request to the merge queue May 21, 2025
Merged via the queue into open-telemetry:main with commit 7a9b049 May 21, 2025
19 of 20 checks passed
@legendecas legendecas deleted the isolated-modules branch May 21, 2025 08:48
@david-luna david-luna mentioned this pull request May 21, 2025
Merged
@david-luna david-luna mentioned this pull request Aug 22, 2025
Open
8 tasks
This was referenced Sep 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @david-luna @trentm
0