E542 Use instrumentation loader to load plugins and instrumentations by obecny · Pull Request #1855 · open-telemetry/opentelemetry-js · GitHub
[go: up one dir, main page]
Skip to content

Use instrumentation loader to load plugins and instrumentations #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2021
Merged

Use instrumentation loader to load plugins and instrumentations #1855

merged 8 commits into from
Feb 5, 2021

Conversation

obecny
Copy link
Member
@obecny obecny commented Jan 20, 2021

Which problem is this PR solving?

Short description of the changes

  1. Removes PluginLoader from @opentelemetry/node
  2. Replaces all usage of plugins configurations with instrumentation loader (examples, docs etc.) both for node and web
    using registerInstrumentations function

@obecny obecny self-assigned this Jan 20, 2021
@obecny obecny changed the title Instr1 Use instrumentation loader to load plugins and instrumentations Jan 20, 2021
vmarchaud
vmarchaud reviewed Jan 20, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #1855 (611f3c3) into main (9981763) will increase coverage by 0.38%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
+ Coverage   92.37%   92.76%   +0.38%     
==========================================
  Files         167      173       +6     
  Lines        5522     5971     +449     
  Branches     1176     1269      +93     
==========================================
+ Hits         5101     5539     +438     
- Misses        421      432      +11
Impacted Files Coverage Δ
packages/opentelemetry-sdk-node/src/sdk.ts 73.68% <66.66%> (-0.23%) ⬇️
...kages/opentelemetry-node/src/NodeTracerProvider.ts 100.00% <100.00%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts 100.00% <100.00%> (ø)
packages/opentelemetry-web/src/utils.ts 94.66% <0.00%> (ø)
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
packages/opentelemetry-web/src/types.ts 100.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 96.82% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 99.23% <0.00%> (ø)
... and 2 more

Flarna
Flarna reviewed Jan 21, 2021
View reviewed changes
Flarna
Flarna reviewed Jan 21, 2021
View reviewed changes
Flarna
Flarna reviewed Jan 21, 2021
View reviewed changes
@obecny obecny mentioned this pull request Jan 21, 2021
Closed
Base automatically changed from master to main January 25, 2021 19:26
vmarchaud
vmarchaud approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member
@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny requested a review from Flarna February 4, 2021 00:03
@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Feb 5, 2021
@obecny obecny merged commit 9cfa92c into open-telemetry:main Feb 5, 2021
@obecny obecny deleted the instr1 branch February 5, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@johnbley johnbley Awaiting requested review from johnbley

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

+2 more reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@obecny obecny

Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use instrumentation loader to load plugins and instrumentations
4 participants
@obecny @dyladan @vmarchaud @Flarna
0