8000 Convert ReferenceMatcherTest to groovy by zeitlinger · Pull Request #14905 · open-telemetry/opentelemetry-java-instrumentation · GitHub
[go: up one dir, main page]
Skip to content

Convert ReferenceMatcherTest to groovy #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 10, 2025
Merged

Convert ReferenceMatcherTest to groovy #14905

merged 10 commits into from
Oct 10, 2025

Conversation

zeitlinger
Copy link
Member

Part of #14803

@zeitlinger zeitlinger self-assigned this Oct 7, 2025
@zeitlinger zeitlinger requested a review from a team as a code owner October 7, 2025 11:21
laurit
laurit reviewed Oct 10, 2025
View reviewed changes
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcherTest.java Outdated
}

@ParameterizedTest
@CsvSource({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you consider using @MethodSource so you wouldn't need to decode the strings?

laurit
laurit reviewed Oct 10, 2025
View reviewed changes
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcherTest.java Outdated
}

@ParameterizedTest
@CsvSource({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you consider using @MethodSource so you wouldn't need to decode the strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea - done!

@zeitlinger zeitlinger force-pushed the convert-grooy-tests-reference branch from 9b6f726 to f125132 Compare October 10, 2025 11:12
@trask trask merged commit e4ac7e7 into open-telemetry:main Oct 10, 2025
81 checks passed
@zeitlinger zeitlinger deleted the convert-grooy-tests-reference branch October 10, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

@zeitlinger zeitlinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeitlinger @laurit @trask
0