8000 Add attribute to camel aws SNS assertions by jaydeluca · Pull Request #14434 · open-telemetry/opentelemetry-java-instrumentation · GitHub
[go: up one dir, main page]
Skip to content

Add attribute to camel aws SNS assertions #14434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Add attribute to camel aws SNS assertions #14434

merged 1 commit into from
Aug 15, 2025

Conversation

jaydeluca
Copy link
Member

#14035 added a new aws attribute, which are emitted by the camel tests. This SNS test is disabled, so our automation didn't pick up on the failure.

It was failing with:

java.lang.AssertionError: [span [SNS.CreateTopic] attribute keys] 
Expecting actual:
  [aws.agent,
    aws.request_id,
    aws.sns.topic.arn,
    http.request.method,
    http.response.status_code,
    network.protocol.version,
    rpc.method,
    rpc.service,
    rpc.system,
    server.address,
    url.full]
to contain exactly in any order:
  [aws.agent,
    url.full,
    rpc.system,
    aws.request_id,
    server.address,
    rpc.service,
    http.response.status_code,
    http.request.method,
    rpc.method,
    network.protocol.version]
but the following elements were unexpected:
  [aws.sns.topic.arn]

Now passes locally:
image

@jaydeluca jaydeluca requested a review from a team as a code owner August 14, 2025 20:25
@laurit laurit merged commit c50eb3c into open-telemetry:main Aug 15, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaydeluca @laurit
0