Fix NPE when consuming kafka messages with null header #14332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed, but I can't determine whether it was due to timeout or some other issue. |
It failed due to a test failure. https://scans.gradle.com/s/3u7t6f5yiuy5e |
jaydeluca
approved these changes
Jul 28, 2025
...va/io/opentelemetry/javaagent/instrumentation/kafkaclients/v0_11/KafkaClientDefaultTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #14329, when a kafka record with a null value is produced,
KafkaConsumerRecordGetterthrows a NPE. If kafka message header is set based on certain conditions (as assumed), there’s a risk that an unintended null value might be inserted, which could lead to an exception.The associated PR suggests a solution for this, and I’ve added three additional modifications to handle the NPE when producing, context propagation, and receive span.
This PR fix #14329