E534 log start of spring boot starter by zeitlinger · Pull Request #13882 · open-telemetry/opentelemetry-java-instrumentation · GitHub
[go: up one dir, main page]
Skip to content

log start of spring boot starter #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

log start of spring boot starter #13882

merged 4 commits into from
Jun 4, 2025
+12 −0

Conversation

zeitlinger
Copy link
Member

to make it easy to see if the starter is applied correctly

@zeitlinger zeitlinger requested a review from a team as a code owner May 20, 2025 11:56
@zeitlinger zeitlinger self-assigned this May 20, 2025
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label May 20, 2025
@zeitlinger zeitlinger force-pushed the spring-starter-log branch from bf55bcc to fbb9755 Compare May 21, 2025 15:00
@trask
Copy link
Member
trask commented May 27, 2025

@zeitlinger how about a "started" message (on successful startup) instead of a "starting" message?

@jeanbisutti
Copy link
Member

The starter version could perhaps be added (not not necessarily in this PR).

@zeitlinger
Copy link
Member Author
zeitlinger commented May 28, 2025 •
edited
Loading

from test

10:00:50.039 [Test worker] INFO  i.o.i.s.a.OpenTelemetryAutoConfiguration - OpenTelemetry Spring Boot starter has been started: 2.17.0-SNAPSHOT

for disabled

10:05:04.203 [Test worker] INFO  i.o.i.s.a.OpenTelemetryAutoConfiguration - OpenTelemetry Spring Boot starter has been disabled

@zeitlinger zeitlinger force-pushed the spring-starter-log branch from fbb9755 to 00ec84c Compare May 28, 2025 08:02
@laurit
Copy link
Contributor
laurit commented May 28, 2025

@zeitlinger how about a "started" message (on successful startup) instead of a "starting" message?

It is hard to tell when it has completely started. Current implementation prints the message when the OpenTelemetry bean is configured. All instrumentations are set up after that. I guess that is why @zeitlinger chose to use starting since it wasn't yet completely started.

@zeitlinger zeitlinger force-pushed the spring-starter-log branch from 0604274 to 6a47524 Compare June 2, 2025 10:44
@zeitlinger @trask
Update instrumentation/spring/spring-boot-autoconfigure/src/main/java…
504570a 
…/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask trask merged commit 5fb48e5 into open-telemetry:main Jun 4, 2025
89 checks passed
@zeitlinger zeitlinger deleted the spring-starter-log branch June 4, 2025 16:11
@yashuatla yashuatla mentioned this pull request Jun 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

@zeitlinger zeitlinger

Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeitlinger @trask @jeanbisutti @laurit @jaydeluca
0