Add tools support to bedrock InvokeModel instrumentation #13832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
approved these changes
May 9, 2025
There was a problem hiding this comment.
thanks for the tedious work @anuraaga. glad to see this at the finish line!
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
...ntime/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/Aws2BedrockRuntimeTest.java
Outdated
Show resolved
Hide resolved
| metric | ||
| .hasName("gen_ai.client.operation.duration") | ||
| .hasUnit("s") | ||
| .hasDescription("GenAI operation duration.") |
There was a problem hiding this comment.
made me look and yes that's literally what the spec says ;) https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-metrics.md#metric-gen_aiclientoperationduration
laurit
reviewed
May 13, 2025
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeImpl.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 13, 2025
.../src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeImpl.java
Outdated
Show resolved
Hide resolved
…nstrumentation into bedrock-invoke-model-tools
laurit
approved these changes
May 15, 2025
|
looking forward the this getting in, as java will have full parity! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses out tools in invoke model payloads which should finish up the bedrock instrumentation. Notably, I think there is full parity with the python instrumentation after this change.
/cc @codefromthecrypt