8000 Delete deprecated property for disabling kafka metrics by laurit · Pull Request #13803 · open-telemetry/opentelemetry-java-instrumentation · GitHub
[go: up one dir, main page]
Skip to content

Delete deprecated property for disabling kafka metrics #13803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Delete deprecated property for disabling kafka metrics #13803

merged 1 commit into from
May 2, 2025

Conversation

laurit
Copy link
Contributor
@laurit laurit commented Apr 30, 2025 •
edited
Loading

otel.instrumentation.kafka.metric-reporter.enabled has been deprecated for over a year

@laurit laurit requested a review from a team as a code owner April 30, 2025 07:31
@SylvainJuge
Copy link
Contributor

Maybe it's a question for SIG meeting, but do you think we should also support this config option when using the YAML JMX metrics ? Or at least explicitly indicate that this config option currently does not influence it ?

@laurit
Copy link
Contributor Author
laurit commented Apr 30, 2025

Maybe it's a question for SIG meeting, but do you think we should also support this config option when using the YAML JMX metrics ? Or at least explicitly indicate that this config option currently does not influence it ?

I don't see a reason why jmx metrics should support a deprecated configuration option. As for otel.instrumentation.kafka-clients-metrics.enabled that is the standard option for enabling an instrumentation. I don't think that jmx metrics should attempt to use it. In the next major version we should disable the kafka-clients-metrics instrumentation by default and let users choose whether they want to use that instrumentation or the jmx one.

@SylvainJuge
Copy link
Contributor

Thanks for your answer @laurit, so for kafka client metrics, like the JVM runtime metrics, there could be two potential sources for metrics:

  • kafka client instrumentation
  • kafka jmx yaml, this one being always opt-in.

This is something that we need to document properly when dealing with kafka client metrics in yaml to prevent any confusion.

@laurit laurit merged commit 1ac6cc0 into open-telemetry:main May 2, 2025
86 checks passed
@laurit laurit deleted the delete-kafka-metrics-enabled-property branch May 2, 2025 07:40
SylvainJuge pushed a commit to SylvainJuge/opentelemetry-java-instrumentation that referenced this pull request May 6, 2025
@laurit @SylvainJuge
Delete deprecated property for disabling kafka metrics (open-telemetr…
2fdc718 
…y#13803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurit @SylvainJuge @trask @jaydeluca
0