10000 [otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter by rajkumar-rangaraj · Pull Request #6229 · open-telemetry/opentelemetry-dotnet · GitHub
[go: up one dir, main page]
Skip to content

[otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 8, 2025
Merged

[otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter #6229

merged 9 commits into from
Apr 8, 2025

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes #6209
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Removed the use of Grpc.Core on legacy frameworks.
  • Updated default protocol to HttpProtobuf for .NET Framework and .NET Standard 2.0.
  • Added runtime NotSupportedException if OtlpExportProtocol.Grpc is configured with the default factory on unsupported targets.
  • Added tests to verify the exception is thrown when default factory is used, and not thrown when a custom factory is supplied.

Follow up

  • Readme update.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner April 3, 2025 23:03
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Apr 3, 2025
@rajkumar-rangaraj rajkumar-rangaraj changed the title Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter [otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter Apr 3, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package labels Apr 3, 2025
Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • Directory.Packages.props: Language not supported
  • src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj: Language not supported

@codecov Codecov
Copy link
codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (f183a6a) to head (e325670).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6229      +/-   ##
==========================================
- Coverage   86.20%   86.18%   -0.03%     
==========================================
  Files         259      258       -1     
  Lines       11854    11793      -61     
==========================================
- Hits        10219    10164      -55     
+ Misses       1635     1629       -6
Flag Coverage Δ
unittests-Project-Experimental 86.11% <100.00%> (+0.21%) ⬆️
unittests-Project-Stable 86.11% <100.00%> (-0.03%) ⬇️
unittests-Solution 86.10% <100.00%> (+0.24%) ⬆️
unittests-UnstableCoreLibraries-Experimental 85.87% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ol/Implementation/ExportClient/OtlpExportClient.cs 100.00% <ø> (ø)
....OpenTelemetryProtocol/OtlpExportProtocolParser.cs 100.00% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 99.09% <100.00%> (+<0.01%) ⬆️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 98.94% <ø> (+3.45%) ⬆️
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 95.03% <100.00%> (+0.76%) ⬆️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 96.66% <100.00%> (+0.15%) ⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 97.40% <100.00%> (+0.14%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Kielek
Kielek reviewed Apr 4, 2025
View reviewed changes
alanwest
alanwest approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member
@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion of marking OtlpExportProtocol.Grpc obsolete for .NET Framwork/.NET Standard.

alanwest
alanwest reviewed Apr 4, 2025
View reviewed changes
Kielek
Kielek reviewed Apr 8, 2025
View reviewed changes
@rajkumar-rangaraj rajkumar-rangaraj merged commit aa73ce3 into open-telemetry:main Apr 8, 2025
49 checks passed
@rajkumar-rangaraj rajkumar-rangaraj mentioned this pull request Apr 29, 2025
Merged
@xiang17 xiang17 mentioned this pull request May 22, 2025
Open
@romerod
Copy link
romerod commented Jul 14, 2025

It would be nice if the information could be added to the breaking change that the endpoint URL needs to be adapted as HttpProtoBuf expects the full Url (as mentioned here in the notes: https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol#otlpexporteroptions) for example: http://localhost:4318/v1/logs for logs.

This was referenced Jul 25, 2025
Closed
Closed
Closed
This was referenced Sep 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 17, 2025
Closed
Closed
Closed
Open
Open
This was referenced Sep 24, 2025
Closed
Closed
Closed
This was referenced Oct 1, 2025
Open
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek left review comments

Copilot code review Copilot Copilot left review comments

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[otlp] Remove Grpc.Core Deprecated Package Dependency from OTLP Exporter
4 participants
@rajkumar-rangaraj @romerod @alanwest @Kielek
0