[otlp] Fix incorrect length handling of Status.Description exceeding 127 bytes #6119
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
reviewed
Jan 31, 2025
CodeBlanch
approved these changes
Jan 31, 2025
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
Kielek
approved these changes
Jan 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
==========================================
- Coverage 86.39% 86.39% -0.01%
==========================================
Files 257 257
Lines 11640 11639 -1
==========================================
- Hits 10056 10055 -1
Misses 1584 1584
|
Closed
1 task
|
@CodeBlanch is this in any release? |
|
@davidfowl Not yet. |
|
@davidfowl Plan to release the hotfix by the end of this week. |
This was referenced Sep 8, 2025
This was referenced Sep 29, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6117
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Fixed an issue with incorrect length encoding of
Status.Descriptionwhen its byte length exceeds 127. The previous behavior resulted in incorrect reporting, causing serialization issues and potential payload corruption. The fix ensures proper length encoding and safe handling of longer descriptions.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes