10000 [sdk-tracing] Allow samplers to set TraceState for propagation-only spans by CodeBlanch · Pull Request #6058 · open-telemetry/opentelemetry-dotnet · GitHub
[go: up one dir, main page]
Skip to content

[sdk-tracing] Allow samplers to set TraceState for propagation-only spans #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2025
Merged

[sdk-tracing] Allow samplers to set TraceState for propagation-only spans #6058

merged 4 commits into from
Jan 15, 2025

Conversation

CodeBlanch
Copy link
Member
@CodeBlanch CodeBlanch commented Jan 10, 2025 •
edited
Loading

Fixes #6054

Changes

  • Adjusts the sampler logic so that the TraceStateString may be set when creating propagation-only spans.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team as a code owner January 10, 2025 19:49
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 10, 2025
@CodeBlanch CodeBlanch mentioned this pull request Jan 10, 2025
Merged
rajkumar-rangaraj
rajkumar-rangaraj approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor
@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch mentioned this pull request Jan 14, 2025
Open
@alanwest alanwest merged commit 3d1f74d into open-telemetry:main Jan 15, 2025
39 checks passed
@codecov Codecov
Copy link
codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.38%. Comparing base (17bbd83) to head (a473cf6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6058      +/-   ##
==========================================
- Coverage   86.39%   86.38%   -0.02%     
==========================================
  Files         257      257              
  Lines       11690    11679      -11     
==========================================
- Hits        10100    10089      -11     
  Misses       1590     1590
Files with missing lines Coverage Δ
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.33% <ø> (-0.03%) ⬇️

@CodeBlanch CodeBlanch deleted the sdk-trace-sampler-tracestate-propagation-only-fix branch January 15, 2025 18:49
This was referenced Sep 8, 2025
Closed
Merged
Merged
Closed
Closed
This was referenced Sep 29, 2025
Closed
Open
Open
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwest alanwest alanwest approved these changes

@Kielek Kielek Kielek approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] TraceStateString is not set when the sampler returns SamplingDecision.Drop
4 participants
@CodeBlanch @alanwest @Kielek @rajkumar-rangaraj
0