8000 [sdk-traces] SamplingResult constructors accept null parameters by Kielek · Pull Request #5614 · open-telemetry/opentelemetry-dotnet · GitHub
[go: up one dir, main page]
Skip to content

[sdk-traces] SamplingResult constructors accept null parameters #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2024
Merged

[sdk-traces] SamplingResult constructors accept null parameters #5614

merged 5 commits into from
May 16, 2024

Conversation

Kielek
Copy link
Member
@Kielek Kielek commented May 14, 2024

Fixes open-telemetry/opentelemetry-dotnet-contrib#1718 (comment)
Design discussion issue #

Changes

SamplingResult constructor accepts null parameters

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Kielek Kielek force-pushed the fix-nullability-SamplingResult branch from 512be15 to 547cd87 Compare May 14, 2024 09:23
@Kielek Kielek force-pushed the fix-nullability-SamplingResult branch from 547cd87 to ee26cbb Compare May 14, 2024 09:38
@codecov Codecov
Copy link
codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (6250307) to head (3136a49).
Report is 226 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5614      +/-   ##
==========================================
+ Coverage   83.38%   85.66%   +2.28%     
==========================================
  Files         297      254      -43     
  Lines       12531    10982    -1549     
==========================================
- Hits        10449     9408    -1041     
+ Misses       2082     1574     -508
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.66% <ø> (?)
unittests-Solution-Stable 85.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Trace/SamplingResult.cs 100.00% <ø> (ø)

... and 114 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 14, 2024 09:45
@Kielek Kielek requested a review from a team May 14, 2024 09:45
@Kielek Kielek mentioned this pull request May 14, 2024
Merged
@Kielek Kielek changed the title SamplingResult constructor accepts null parameters SamplingResult constructors accept null parameters May 14, 2024
reyang
reyang reviewed May 14, 2024
View reviewed changes
CodeBlanch
CodeBlanch reviewed May 14, 2024
View reviewed changes
@reyang reyang added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package and removed pkg:OpenTelemetry labels May 14, 2024
Kielek
Kielek commented May 15, 2024
View reviewed changes
@CodeBlanch CodeBlanch changed the title SamplingResult constructors accept null param B99B eters [sdk-traces] SamplingResult constructors accept null parameters May 16, 2024
@CodeBlanch CodeBlanch added the traces Tracing signal related label May 16, 2024
@CodeBlanch CodeBlanch merged commit 808abc8 into open-telemetry:main May 16, 2024
@Kielek Kielek mentioned this pull request Jun 20, 2024
Merged
This was referenced Sep 8, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@reyang reyang reyang approved these changes

+1 more reviewer

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package traces Tracing signal related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kielek @rajkumar-rangaraj @reyang @vishweshbankwar @CodeBlanch
0