8000 resolve socket leak in fluentd exporter by KSSKarthikeya · Pull Request #585 · open-telemetry/opentelemetry-cpp-contrib · GitHub
[go: up one dir, main page]
Skip to content

resolve socket leak in fluentd exporter #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

resolve socket leak in fluentd exporter #585

merged 2 commits into from
Oct 3, 2025

Conversation

KSSKarthikeya
Copy link
Contributor
@KSSKarthikeya KSSKarthikeya commented Oct 3, 2025 •
edited
Loading

fluentd_exporter.cc Connect() function is causing socket leak when the connection fails.

Test results: Open FDs count stopped increasing after fix.

Every 2.0s: /workspace/pid_watch.sh                                                                qemux86-64: Fri Oct  3 20:15:02 2025

Time: 2025-10-03 20:15:02  PID: 1827
---- /proc/1827/limits ----
Limit                     Soft Limit           Hard Limit           Units
Max open files            1024                 4096                 files
---- FD usage ----
open_fds: 11  max_fds: 1024 4096
---- Socket counts (tcp/udp/unix) ----
tcp lines: 14
udp lines: 4
unix lines: 11

Every 2.0s: /workspace/pid_watch.sh                                                                  qemux86-64: Fri Oct  3 20:16:59 2025

Time: 2025-10-03 20:16:59  PID: 1827
---- /proc/1827/limits ----
Limit                     Soft Limit           Hard Limit           Units
Max open files            1024                 4096                 files

---- FD usage ----
open_fds: 11  max_fds: 1024 4096
---- Socket counts (tcp/udp/unix) ----
tcp lines: 14
udp lines: 4
unix lines: 11

@KSSKarthikeya KSSKarthikeya requested a review from a team as a code owner October 3, 2025 17:24
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Oct 3, 2025 •
edited
Loading

CLA Signed

  • ✅login: KSSKarthikeya / name: Karthikeya K S S / (6823050)
  • ✅login: KSSKarthikeya / name: Karthikeya K S S / (6823050, 991f0cb)

The committers listed above are authorized under a signed CLA.

ThomsonTan
ThomsonTan reviewed Oct 3, 2025
View reviewed changes
exporters/fluentd/src/log/fluentd_exporter.cc Outdated
if (!socket_.invalid()) {
socket_.close();
}
connected_ = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this set of connected_ to false necessary? Seems unnecessary because it is already in false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomsonTan , thanks for pointing that out, I have removed it.
Can this be approved ?

@ThomsonTan ThomsonTan merged commit 78e2a71 into open-telemetry:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSSKarthikeya @ThomsonTan
0