8000 [METRICS SDK] Fix copying overflow attributes in attribute hashmap by ThomsonTan · Pull Request #3651 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[METRICS SDK] Fix copying overflow attributes in attribute hashmap #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 25, 2025
Merged

[METRICS SDK] Fix copying overflow attributes in attribute hashmap #3651

merged 8 commits into from
Sep 25, 2025

Conversation

ThomsonTan
Copy link
Contributor
@ThomsonTan ThomsonTan commented Sep 22, 2025 •
edited
Loading

Fixes #3638

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov Codecov
Copy link
codecov bot commented Sep 23, 2025 •
edited
Loading
8000

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (f788e35) to head (178b4ae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.00%     
==========================================
  Files         221      221              
  Lines        7129     7135       +6     
==========================================
+ Hits         6423     6428       +5     
- Misses        706      707       +1
Files with missing lines Coverage Δ
...entelemetry/sdk/metrics/state/attributes_hashmap.h 98.42% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThomsonTan ThomsonTan marked this pull request as ready for review September 23, 2025 04:36
@ThomsonTan ThomsonTan requested a review from a team as a code owner September 23, 2025 04:36
@ThomsonTan ThomsonTan added the pr:please-review This PR is ready for review label Sep 23, 2025
@ThomsonTan ThomsonTan mentioned this pull request Sep 25, 2025
Closed
@lalitb lalitb mentioned this pull request Sep 25, 2025
Merged
3 tasks
@ThomsonTan ThomsonTan changed the title Fix copying overflow attributes in attribute hashmap [METRICS SDK] Fix copying overflow attributes in attribute hashmap Sep 25, 2025
@marcalff marcalff merged commit 8f3ec92 into open-telemetry:main Sep 25, 2025
66 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meter::Collect could return 1 less aggregated metric than the declared cardinality limit
3 participants
@ThomsonTan @lalitb @marcalff
0