[BUILD] Use -dev versions in main branch #3609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 220 220
Lines 7069 7069
=======================================
Hits 6364 6364
Misses 705 705
🚀 New features to boost your workflow:
|
dbarker
reviewed
Aug 26, 2025
ThomsonTan
reviewed
Aug 26, 2025
ThomsonTan
reviewed
Aug 26, 2025
|
|
||
| std::string actual = OPENTELEMETRY_VERSION; | ||
| EXPECT_EQ(actual, expected); | ||
| /* OPENTELEMETRY_VERSION may contain a -dev suffix */ |
There was a problem hiding this comment.
Check the exact suffix?
There was a problem hiding this comment.
The -dev convention for main is arbitrary, we can potentially have also -rc, -rfc or anything, so the -dev part can not be hardcoded in the unit test itself.
There is no #define OPENTELEMETRY_VERSION_SUFFIX "-dev" either (and I don't think we should add it), so there is nothing to compare the suffix against to validate the full version string.
This code change in the unit test is sufficient to pass with both "1.23.0" and "1.23.0-dev".
lalitb
approved these changes
Aug 29, 2025
dbarker
approved these changes
Aug 29, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3583
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes