8000 [BUILD] Remove cmake support for thrift as Jaeger was removed by ThomsonTan · Pull Request #3604 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[BUILD] Remove cmake support for thrift as Jaeger was removed #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

[BUILD] Remove cmake support for thrift as Jaeger was removed #3604

merged 1 commit into from
Aug 22, 2025

Conversation

ThomsonTan
Copy link
Contributor

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team as a code owner August 22, 2025 20:33
@netlify Netlify
Copy link
netlify bot commented Aug 22, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6ef176a
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68a8d41b2e99d900088688bd

@codecov Codecov
Copy link
codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (fae81fa) to head (6ef176a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.01%     
==========================================
  Files         220      220              
  Lines        7069     7069              
==========================================
- Hits         6364     6363       -1     
- Misses        705      706       +1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dbarker
dbarker approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member
@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit 9d68c19 into open-telemetry:main Aug 22, 2025
70 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbarker dbarker dbarker approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomsonTan @dbarker @marcalff
0