8000 [REMOVAL] remove unused ci bash scripts by dbarker · Pull Request #3541 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[REMOVAL] remove unused ci bash scripts #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

[REMOVAL] remove unused ci bash scripts #3541

merged 1 commit into from
Jul 15, 2025

Conversation

dbarker
Copy link
Member
@dbarker dbarker commented Jul 15, 2025

#3486 changed third party package build and install to use a single CMake project and the ExternalProject module. The old ci bash scripts for installing abseil, protobuf, and googletest can be removed.

Changes

  • removes install_abseil.sh, install_protobuf.sh, and setup_googletest.sh

For significant contributions pleas 8000 e make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit a1280e3
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6876923b3517cb0008147888

@codecov Codecov
Copy link
codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (4da9b67) to head (a1280e3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3541   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files         219      219           
  Lines        7044     7044           
=======================================
  Hits         6338     6338           
  Misses        706      706
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review July 15, 2025 18:50
@dbarker dbarker requested a review from a team as a code owner July 15, 2025 18:50
lalitb
lalitb approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member
@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 6fed48c into open-telemetry:main Jul 15, 2025
70 checks passed
@dbarker dbarker deleted the removal_unused_ci_scripts branch July 15, 2025 20:53
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarker @lalitb @marcalff
0