8000 [CONFIGURATION] File configuration - sampler model by marcalff · Pull Request #3468 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[CONFIGURATION] File configuration - sampler model #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 27, 2025
Merged

[CONFIGURATION] File configuration - sampler model #3468

merged 8 commits into from
Jun 27, 2025

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Jun 9, 2025 •
edited
Loading

Contributes to #2481

This is a partial fix, that implements supporting declarations.

Changes

Please provide a brief description of the changes here.

  • Implement the sampler model for file configuration.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Jun 9, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 1e11e06
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/685eda21aafe740008e83a25

@marcalff marcalff marked this pull request as ready for review June 9, 2025 10:19
@marcalff marcalff requested a review from a team as a code owner June 9, 2025 10:19
@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 9, 2025
@marcalff marcalff mentioned this pull request Jun 9, 2025
Open
62 tasks
@codecov Codecov
Copy link
codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (89b6d0f) to head (1e11e06).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3468   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         219      219           
  Lines        7051     7051           
=======================================
  Hits         6343     6343           
  Misses        708      708
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dbarker
dbarker approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member
@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 82bddef into main Jun 27, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_sampler_model branch June 27, 2025 22:35
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@dbarker dbarker dbarker approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @lalitb @dbarker
0