[SDK] Fix MetricProducer interface #3413
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
==========================================
- Coverage 90.06% 90.06% -0.00%
==========================================
Files 212 212
Lines 6939 6937 -2
==========================================
- Hits 6249 6247 -2
Misses 690 690
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks for the PR Yash, having two instances of metric_filter_ indeed looks to be an oversight.
Should we remove the metric_filter_ member from MetricCollector instead, in order to closer to match the description of the specs?
I was not involved in the creation of the spec, but I don't think they intended to add member variables to interfaces (since that no longer would be a pure interface) . I think they just meant that child classes of MetricCollector should take in metric_filter_. Either that or as a parameter to |
[SDK] Fix MetricProducer interface (open-telemetry#3413)
Fixes #3412
Changes
Cleans up the
MetricProducerinterface by removing the unusedmetric_filter_parameter.CHANGELOG.mdupdated for non-trivial ch 8000 anges