10BC0 [CI] disable bzip2 in conan builds by dbarker · Pull Request #3352 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]

Skip to content

Conversation

dbarker
Copy link
Member
@dbarker dbarker commented Apr 7, 2025

the cmake install tests based on conan are failing due to the bzip2 server being down. Remove bzip2 from the build it is not needed.

Changes

  • remove bzip2 from the install/conan/conanfile* files

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner April 7, 2025 21:47
Copy link
netlify bot commented Apr 7, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ed201b7
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67f447fbf811e4000889d844

@dbarker
Copy link
Member Author
dbarker commented Apr 7, 2025

@marcalff the server conan uses to pull down bzip2 is down. This PR will stop the ci workflow from trying to build bzip2. A longer term solution is to cache the conan builds, but this should unblock ci for now.

@marcalff marcalff changed the title disable bzip2 in conan builds [CI] disable bzip2 in conan builds Apr 7, 2025
Copy link
codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (b6908f0) to head (ed201b7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3352   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         210      210           
  Lines        6502     6502           
=======================================
  Hits         5822     5822           
  Misses        680      680           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 99a0328 into open-telemetry:main Apr 7, 2025
66 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Apr 8, 2025
@dbarker dbarker deleted the fix_disable_bzip2_in_conan_tests branch April 19, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0