[DEVCONTAINER] fix grpc install #3325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the cxx standard and not allow extensions. echo the cmake build args
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
+ Coverage 89.51% 89.52% +0.02%
==========================================
Files 210 210
Lines 6526 6526
==========================================
+ Hits 5841 5842 +1
+ Misses 685 684 -1 🚀 New features to boost your workflow:
|
6 tasks
ThomsonTan
reviewed
Mar 26, 2025
| -DCMAKE_CXX_STANDARD_REQUIRED=ON | ||
| -DCMAKE_CXX_EXTENSIONS=OFF | ||
| -DgRPC_BUILD_TESTS=OFF | ||
| -DgRPC_BUILD_GRPC_CSHARP_PLUGIN=OFF |
There was a problem hiding this comment.
Are the plug-ins default on? Or need set CPP plug-in as ON?
There was a problem hiding this comment.
Yeah all are on by default except the OTEL plugin. I'll push a commit to explicitly set the cpp plugin on to be consistent.
ThomsonTan
approved these changes
Mar 27, 2025
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Mar 27, 2025
[DEVCONTAINER] fix grpc install (open-telemetry#3325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fix to PR #3270
Changes
For sig 8000 nificant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes