8000 [BUILD] Fix elasticsearch exporter json compatibility by dbarker · Pull Request #3313 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[BUILD] Fix elasticsearch exporter json compatibility #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2025
Merged

[BUILD] Fix elasticsearch exporter json compatibility #3313

merged 5 commits into from
Mar 25, 2025

Conversation

dbarker
Copy link
Member
@dbarker dbarker commented Mar 22, 2025

Fixes #3312

The system package of nlohmann_json is version 3.10.5 on Ubuntu 22.04.

Changes

  • Add a template specializatio 8000 n of the json_assign_visitor to handle nostd::span attribute values.
  • Switch one runner that builds the elastic search exporter (runs ./ci/do_ci.sh cmake.test) to Ubuntu 22.04 and CXX_STANDARD=17

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner March 22, 2025 00:17
@netlify Netlify
Copy link
netlify bot commented Mar 22, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit c8d8987
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67e22d1a4b88cc000898bd3f

@codecov Codecov
Copy link
codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (2c9b68f) to head (8309565).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.02%     
==========================================
  Files         210      210              
  Lines        6522     6522              
==========================================
+ Hits         5837     5838       +1     
+ Misses        685      684       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

marcalff
marcalff approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

owent
owent requested changes Mar 24, 2025
View reviewed changes
owent
owent approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member
@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@lalitb lalitb merged commit 216f3f7 into open-telemetry:main Mar 25, 2025
57 checks passed
@dbarker dbarker mentioned this pull request Mar 26, 2025
Closed
6 tasks
@dbarker dbarker deleted the fix_elasticsearch_json_compatibility branch March 31, 2025 16:14
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcalff marcalff marcalff approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@owent owent owent approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Elasticsearch exporter build fails with nlohmann_json version 3.10.5 and older

5 participants

@dbarker @ThomsonTan @owent @marcalff @lalitb
0