[BUILD] Adding typecast without whom c++latest build fails #3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3281 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 205 205
Lines 6407 6407
=======================================
Hits 5635 5635
Misses 772 772 |
owent
approved these changes
Feb 19, 2025
marcalff
approved these changes
Feb 19, 2025
ThomsonTan
approved these changes
Feb 19, 2025
|
@jeremicmilan could you please sign the CLA then we could get this merged. |
|
@ThomsonTan, I did. It's waiting on approval. |
|
Ok, I just signed with my personal account. I did not read through carefully the first time around. |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Feb 20, 2025
Adding typecast without whom c++26 build fails (open-telemetry#3281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3237
Changes
Adding typecast without whom
c++latestbuild fails. More details in #3237< 8000 /a>.