8000 [CI] Add GRPC in maintainer CI by marcalff · Pull Request #3248 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[CI] Add GRPC in maintainer CI #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2025
Merged

[CI] Add GRPC in maintainer CI #3248

merged 3 commits into from
Jan 21, 2025

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Jan 17, 2025 •
edited
Loading

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Use grpc in maintainer CI : WITH_OTLP_GRPC=ON
  • Fixed build warnings in grpc exporter
  • Fixed remaining include-what-you-use warnings

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d6bbd4a
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/678acfd8e3ed0100087dd0fe

@codecov Codecov
Copy link
codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (25f7a13) to head (d6bbd4a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3248   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files         198      198           
  Lines        6308     6308           
=======================================
  Hits         5537     5537           
  Misses        771      771
Files with missing lines Coverage Δ
...lude/opentelemetry/sdk/common/global_log_handler.h 46.16% <ø> (ø)
...ude/opentelemetry/sdk/resource/resource_detector.h 100.00% <ø> 8000 (ø)

@marcalff marcalff changed the title Add GRPC in maintainer CI [CI] Add GRPC in maintainer CI Jan 17, 2025
@marcalff
Copy link
Member Author

@owent

Please check the following code:

async_interface_base *async() override { return &async_interface_; }
async_interface_base *experimental_async() { return &async_interface_; }

I could not figure out how to adjust this for grpc 1.33 or grpc 1.39.

I suspect the following logic:

// Some old toolchains can only use gRPC 1.33 and it's experimental.
#  if defined(GRPC_CPP_VERSION_MAJOR) && \
      (GRPC_CPP_VERSION_MAJOR * 1000 + GRPC_CPP_VERSION_MINOR) >= 1039

to not work as intended,
given how symbol GRPC_CPP_VERSION_MAJOR was only added in grpc version 1.51 by this commit:

commit 8696d49e23490d7f658c2fe531daebfcceaecf15
Author: Esun Kim <veblush@google.com>
Date:   Mon Nov 7 11:31:00 2022 -0800

    Added version macros (#31033)

@marcalff marcalff marked this pull request as ready for review January 17, 2025 22:26
@marcalff marcalff requested a review from a team as a code owner January 17, 2025 22:26
@marcalff marcalff added the pr:please-review This PR is ready for review label Jan 17, 2025
@marcalff marcalff mentioned this pull request Jan 17, 2025
Merged
3 tasks
@marcalff marcalff merged commit d2ff95a into open-telemetry:main Jan 21, 2025
57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

Assignees
No one assigned
Labels
pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalff @owent
0