8000 [BUILD] Fix error ‘uint8_t’ does not name a type with gcc-15 by AngryLoki · Pull Request #3240 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[BUILD] Fix error ‘uint8_t’ does not name a type with gcc-15 #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

[BUILD] Fix error ‘uint8_t’ does not name a type with gcc-15 #3240

merged 1 commit into from
Jan 10, 2025

Conversation

AngryLoki
Copy link
Contributor
@AngryLoki AngryLoki commented Jan 10, 2025 •
edited by marcalff
Loading

Fixes #3239

Changes

Added missing cstdint header for uint8_t type in api/include/opentelemetry/logs/severity.h.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@AngryLoki AngryLoki requested a review from a team as a code owner January 10, 2025 15:35
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Jan 10, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link
netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs ready!

Name Link
🔨 Latest commit 1977081
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67813e4029e84d0008efe231
😎 Deploy Preview https://deploy-preview-3240--opentelemetry-cpp-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marcalff
marcalff approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Fix error ‘uint8_t’ does not name a type with gcc-15 [BUILD] Fix error ‘uint8_t’ does not name a type with gcc-15 Jan 10, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (d19eb32) to head (1977081).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3240   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737

@lalitb lalitb merged commit 57114c5 into open-telemetry:main Jan 10, 2025
57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
@robomics robomics mentioned this pull request Jun 6, 2025
Merged
3 tasks
@iyanmv iyanmv mentioned this pull request Sep 4, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling severity.h with gcc-15 fails
3 participants
@AngryLoki @lalitb @marcalff
0