8000 [SEMCONV] Metrics are incorrectly prefixed with `metric.` by marcalff · Pull Request #3228 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[SEMCONV] Metrics are incorrectly prefixed with metric. #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

[SEMCONV] Metrics are incorrectly prefixed with metric. #3228

merged 1 commit into from
Jan 7, 2025

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Jan 6, 2025 •
edited
Loading

Fixes #3226

Changes

Please provide a brief description of the changes here.

  • Fixed the semconv code generation for metrics, to emit the proper metric name

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 23c7a98
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/677c4e0da0b96700082c26f3

@marcalff marcalff marked this pull request as ready for review January 6, 2025 21:47
@marcalff marcalff requested a review from a team as a code owner January 6, 2025 21:47
@codecov Codecov
Copy link
codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (bb68f49) to head (23c7a98).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3228   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737

@marcalff marcalff merged commit 3b89346 into open-telemetry:main Jan 7, 2025
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jan 7, 2025
@malkia
Merge pull request #138 from open-telemetry/main
e536f44 
[SEMCONV] Metrics are incorrectly prefixed with `metric.` (open-telemetry#3228)
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
@marcalff marcalff deleted the fix_metric_semconv branch February 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SEMCONV] Metrics are incorrectly prefixed with metric.

2 participants

@marcalff @lalitb
0