8000 [BUILD] Build break using protoc 3.14 by marcalff · Pull Request #3211 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[BUILD] Build break using protoc 3.14 #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

[BUILD] Build break using protoc 3.14 #3211

merged 2 commits into from
Dec 17, 2024

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Dec 17, 2024 •
edited
8000 Loading

Fixes #3209

Changes

Please provide a brief description of the changes here.

  • Fixed a build break in unit tests, when using protoc 3.14

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 0159170
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6761a5eed79c3d0008dec1ab

@marcalff marcalff added pr:please-review This PR is ready for review issue:blocking This issue is preventing other fixes labels Dec 17, 2024
@marcalff
Copy link
Member Author

This PR is ready for review.

Build breaks in CI will resolve themselves once #3207 is merged.

@marcalff marcalff marked this pull request as ready for review December 17, 2024 10:38
@marcalff marcalff requested a review from a team as a code owner December 17, 2024 10:38
@codecov Codecov
Copy link
codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (b741815) to head (0159170).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3211   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         195      195           
  Lines        6154     6154           
=======================================
  Hits         5405     5405           
  Misses        749      749

@marcalff marcalff merged commit 1cbea09 into open-telemetry:main Dec 17, 2024
57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
@marcalff marcalff deleted the fix_build_protoc_3.14.0 branch February 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break using protoc 3.14
2 participants
@marcalff @lalitb
0