8000 [TEST] Build the singleton test on windows. by marcalff · Pull Request #3183 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[TEST] Build the singleton test on windows. #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 17, 2024
Merged

[TEST] Build the singleton test on windows. #3183

merged 13 commits into from
Dec 17, 2024

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Dec 3, 2024 •
edited
Loading

Contributes to #2534

Note that the original issue in #2534 is not fixed.
This change only adds unit tests to reproduce the issue, and show the current failure in windows.

Changes

Please provide a brief description of the changes here.

  • Port the singleton unit test in API to build with windows
  • Added verbose output for unit tests in CI on windows
  • Commented the failing test cases on windows

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6cefbe4
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6761afcd89a69300082534ad

@codecov Codecov
Copy link
codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (1cbea09) to head (6cefbe4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3183      +/-   ##
==========================================
+ Coverage   87.82%   87.83%   +0.02%     
==========================================
  Files         195      195              
  Lines        6154     6154              
==========================================
+ Hits         5404     5405       +1     
+ Misses        750      749       -1

see 1 file with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review December 3, 2024 15:40
@marcalff marcalff requested a review from a team as a code owner December 3, 2024 15:40
@marcalff marcalff changed the title Build the singleton test on windows. [TEST] Build the singleton test on windows. Dec 3, 2024
@marcalff marcalff added the pr:please-review This PR is ready for review label Dec 4, 2024
ThomsonTan
ThomsonTan reviewed Dec 4, 2024
View reviewed changes
@lalitb lalitb requested a review from ThomsonTan December 17, 2024 16:19
@marcalff marcalff merged commit 902ee88 into open-telemetry:main Dec 17, 2024
52 of 57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
@marcalff marcalff deleted the fix_singleton_test_build branch February 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan Awaiting requested review from ThomsonTan

Assignees
No one assigned
Labels
pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalff @ThomsonTan @lalitb
0