8000 [BUILD] Do not set OTELCPP_PROTO_PATH in the CMake cache by marcalff · Pull Request #3160 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[BUILD] Do not set OTELCPP_PROTO_PATH in the CMake cache #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2024
Merged

[BUILD] Do not set OTELCPP_PROTO_PATH in the CMake cache #3160

merged 2 commits into from
Nov 24, 2024

Conversation

marcalff
Copy link
Member

Do not set OTELCPP_PROTO_PATH in the CMake cache.

This is an oversight from:

Setting OTELCPP_PROTO_PATH in the cache prevents to use this flag as intended.

Changes

Please provide a brief description of the changes here.

  • Do not set OTELCPP_PROTO_PATH in the cmake cache, so it can be set by the calling makefiles.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Nov 22, 2024 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 2440bc8
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6743742e397e5e000815215d

@marcalff marcalff marked this pull request as ready for review November 22, 2024 11:35
@marcalff marcalff requested a review from a team as a code owner November 22, 2024 11:35
@marcalff marcalff added the pr:please-review This PR is ready for review label Nov 22, 2024
@codecov Codecov
Copy link
codecov bot commented Nov 22, 2024 •
edited
Loading 8000

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (fcdd526) to head (2440bc8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3160   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747
---- 🚨 Try these New Features:

@marcalff marcalff merged commit c1ef416 into open-telemetry:main Nov 24, 2024
57 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 26, 2024
Merged
@marcalff marcalff deleted the fix_proto_cache_path branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

Assignees
No one assigned
Labels
pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalff @owent
0