[CI] speed up clang-tidy workflow
#3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 87.12% 87.82% +0.70%
==========================================
Files 200 195 -5
Lines 6109 6146 +37
==========================================
+ Hits 5322 5397 +75
+ Misses 787 749 -38 |
clang-tidy workflowclang-tidy workflow
marcalff
approved these changes
Nov 15, 2024
|
@sjinks Thanks for the fix, it is most welcome. We are falling behind with basic checks like include-what-you-use (almost done) and clang-tidy (preliminary CI was set in place, but cleanup has barely started yet). Contributions like yours, from someone having both the skills and the willingness to help, are definitively appreciated. |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Nov 15, 2024
[CI] speed up `clang-tidy` workflow (open-telemetry#3148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR speeds up the
clang-tidyworkflow. Becauseclang-tidyonly needs a compilation database generated by CMake, there's no need to waste time compiling the source code.The only target we need to build is
opentelemetry_protobecause some other files depend on the files generated by the Protobuf compiler.We can achieve further performance improvements by running
clang-tidyjobs in parallel.Before: 43:06 (number of warnings: 114)
After: 14:30 (number of warnings: 114)
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes