8000 [SEMANTIC CONVENTIONS] Migration to weaver by marcalff · Pull Request #3105 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[SEMANTIC CONVENTIONS] Migration to weaver #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 13, 2024
Merged

[SEMANTIC CONVENTIONS] Migration to weaver #3105

merged 25 commits into from
Nov 13, 2024

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Oct 16, 2024 •
edited
Loading

Fixes #3089

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link
netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d125af2
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6733d8083338d700088ae79c

@marcalff marcalff changed the title Migration to weaver - work in progress [WIP] Migration to weaver Oct 16, 2024
@codecov Codecov
Copy link
codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (497eaf4) to head (d125af2).
Report is 162 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3105      +/-   ##
==========================================
+ Coverage   87.12%   87.85%   +0.73%     
==========================================
  Files         200      195       -5     
  Lines        6109     6136      +27     
==========================================
+ Hits         5322     5390      +68     
+ Misses        787      746      -41
Files with missing lines Coverage Δ
sdk/src/resource/resource.cc 96.30% <100.00%> (ø)
sdk/src/resource/resource_detector.cc 100.00% <100.00%> (ø)

... and 108 files with indirect coverage changes

@lmolkova lmolkova mentioned this pull request Oct 17, 2024
Closed
16 tasks
@marcalff marcalff marked this pull request as ready for review October 30, 2024 22:27
@marcalff marcalff requested a review from a team as a code owner October 30, 2024 22:27
@marcalff
Copy link
Member Author

Reviewers:

Generated code

Code under api/include/opentelemetry/semconv is generated automatically.
There is no need to review each file, just sample a few.

Make sure to review at least:

  • file schema_url.h, because it is special
  • an xxx_attributes.h file,
  • an xxx_metrics.h file.

Weaver generation

All relevant code is under buildscripts/semantic-convention.

Please review:

  • file weaver.yaml
  • every jinja templates (*.j2 files)
  • the generator script

Example of usage

Various examples, tests, sdk files have been updated, and now use the new semconv generated code.

@marcalff
Copy link
Member Author

@open-telemetry/weaver-maintainers @open-telemetry/cpp-maintainers Please review, and provide feedback.

@marcalff marcalff changed the title [WIP] Migration to weaver [RFC] Migration to weaver Oct 30, 2024
@marcalff marcalff requested review from jsuereth and lquerel October 30, 2024 22:59
lquerel
lquerel approved these changes Oct 31, 2024
View reviewed changes
Copy link
@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice use of Weaver. Thank you for this migration.

@marcalff marcalff changed the title [RFC] Migration to weaver [SEMANTIC CONVENTIONS] Migration to weaver Oct 31, 2024
@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 31, 2024
@marcalff marcalff added the deprecation Deprecation label Nov 9, 2024
lalitb
lalitb reviewed Nov 11, 2024
View reviewed changes
lalitb
lalitb approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member
@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it.

@marcalff marcalff added ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) and removed pr:please-review This PR is ready for review labels Nov 13, 2024
@marcalff marcalff merged commit f7a9aea into open-telemetry:main Nov 13, 2024
56 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 26, 2024
Merged
@sjinks sjinks mentioned this pull request Jan 4, 2025
Closed
@marcalff marcalff deleted the migrate_semconv_weaver branch February 5, 2025 20:59
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

+1 more reviewer

@lquerel lquerel lquerel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deprecation Deprecation ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate semantic conventions code generation to weaver

3 participants

@marcalff @lquerel @lalitb
0