[INSTALL] Resolve dependencies in opentelemetry-cpp-config.cmake #3094
Conversation
Before this change, consumers of the exported CMake targets had to know which dependencies are needed to get the transitive target dependencies like `absl::*`, `gRPC::grpc++`, or `protobuf::libprotobuf`.
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3094 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
|
|
What warnings? Calling |
|
I now realize that my earlier response might has come across as rude, which I did not intend.
May I humbly request that you take another look? |
Sorry, calling |
Now we also resolve `OpenTracing`, and `prometheus-cpp`. If necessary, `CURL` and `ZLIB` are also resolved.
|
Thanks for the heads-up! I added the rest. |
| find_dependency(Threads) | ||
|
|
||
| if(@WITH_ABSEIL@) | ||
| find_dependency(absl) |
There was a problem hiding this comment.
I add absl in #3041 , which alos consider protobuf's version and gRpc
Before this change, consumers of the exported CMake targets had to know which dependencies are needed to get the transitive target dependencies like
absl::*,gRPC::grpc++, orprotobuf::libprotobuf.Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes