8000 [EXAMPLE] Clean the tracer initialization in OStream example by ThomsonTan · Pull Request #3051 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]

Skip to content

Conversation

ThomsonTan
Copy link
Contributor

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in pu 8000 blic API reviewed

@ThomsonTan ThomsonTan requested a review from a team September 4, 2024 18:36
@ThomsonTan ThomsonTan changed the title [EXAMPLE] Simple the tracer initialization in OStream example [EXAMPLE] Clean the tracer initialization in OStream example Sep 4, 2024
Copy link
codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (497eaf4) to head (7d28eef).
Report is 127 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
+ Coverage   87.12%   87.66%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5866     -243     
==========================================
- Hits         5322     5142     -180     
+ Misses        787      724      -63     

see 124 files with indirect coverage changes

@lalitb
Copy link
Member
lalitb commented Sep 5, 2024

What is this change for - better naming for variables ? Can we ensure it is consistent across other examples, e.g. logs_simple also follow existing naming.

@ThomsonTan
Copy link
Contributor Author

What is this change for - better naming for variables ? Can we ensure it is consistent across other examples, e.g. logs_simple also follow existing naming.

Yes, mostly about naming. Applied the same change to logs_example. Will look other examples later.

@marcalff marcalff merged commit d623bc5 into open-telemetry:main Sep 5, 2024
52 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Sep 6, 2024
[EXAMPLE] Clean the tracer initialization in OStream example (open-telemetry#3051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0