8000 [Code Health] include-what-you-use cleanup, part 4 by marcalff · Pull Request #3040 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[Code Health] include-what-you-use cleanup, part 4 #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 11, 2024
Merged

[Code Health] include-what-you-use cleanup, part 4 #3040

merged 14 commits into from
Sep 11, 2024

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Aug 28, 2024 •
edited
Loading

Contributes to #2054

Changes

Please provide a brief description of the changes here.

  • completed cleanup of sdk/include
  • completed cleanup of sdk/src
  • major cleanup of sdk/test, with only 8 issues remaining
  • total number of warnings decreased from 91 in branch main, to 29 in this PR.

The remaining sdk warnings need more analysis, and will be fixed in a different PR.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team August 28, 2024 21:33
@marcalff marcalff marked this pull request as draft August 28, 2024 21:34
@codecov Codecov
Copy link
codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (497eaf4) to head (293e457).
Report is 130 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3040      +/-   ##
==========================================
+ Coverage   87.12%   87.79%   +0.68%     
==========================================
  Files         200      195       -5     
  Lines        6109     5953     -156     
==========================================
- Hits         5322     5226      -96     
+ Misses        787      727      -60
Files with missing lines Coverage Δ
...entelemetry/exporters/memory/in_memory_span_data.h 100.00% <ø> (ø)
...lemetry/exporters/memory/in_memory_span_exporter.h 89.48% <ø> (-1.43%) ⬇️
...include/opentelemetry/ext/http/common/url_parser.h 93.94% <ø> (+1.94%) ⬆️
...include/opentelemetry/sdk/common/attribute_utils.h 89.84% <ø> (-1.07%) ⬇️
...clude/opentelemetry/sdk/common/attributemap_hash.h 90.00% <ø> (+6.13%) ⬆️
...include/opentelemetry/sdk/common/circular_buffer.h 100.00% <ø> (ø)
...e/opentelemetry/sdk/common/circular_buffer_range.h 100.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/observer_result.h 100.00% <ø> (+7.70%) ⬆️
...entelemetry/sdk/metrics/state/attributes_hashmap.h 92.19% <ø> (-0.23%) ⬇️
...telemetry/sdk/metrics/state/multi_metric_storage.h 81.82% <ø> (-1.51%) ⬇️
... and 9 more

... and 109 files with indirect coverage changes

@marcalff marcalff changed the title IWYU cleanup, part 4 [Code Health] include-what-you-use cleanup, part 4 Aug 28, 2024
@marcalff
Copy link
Member Author
marcalff commented Sep 5, 2024

Massive cleanup in sdk and misc places, now ready for review.

@marcalff marcalff marked this pull request as ready for review September 5, 2024 21:55
@marcalff marcalff added the pr:please-review This PR is ready for review label Sep 5, 2024
esigo
esigo approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member
@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the PR :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Sep 11, 2024
@marcalff marcalff merged commit c6d3945 into open-telemetry:main Sep 11, 2024
52 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 8, 2024
Merged
@marcalff marcalff deleted the fix_iwyu_cleanup_4 branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esigo esigo esigo approved these changes

+1 more reviewer

@punya punya punya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @punya @esigo
0