10BC0 [TEST] Fix opentelemetry-collector bind address by marcalff · Pull Request #2989 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[TEST] Fix opentelemetry-collector bind address #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

[TEST] Fix opentelemetry-collector bind address #2989

merged 2 commits into from
Jul 3, 2024
+4 −0

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented Jul 3, 2024 •
edited
Loading

Changes

Please provide a brief description of the changes here.

The opentelemetry-collector release v1.11.0/v0.104.0 contains a breaking change:

The otlpreceiver now uses localhost by default instead of 0.0.0.0. This may break the receiver in containerized environments like Kubernetes. If you depend on 0.0.0.0 disable the component.UseLocalHostAsDefaultHost feature gate or explicitly set the endpoint to 0.0.0.0.

This broke the functional tests in CI.

Adjust the opentelemetry-collector configuration files used in functional tests to set explicitly an endpoint.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov Codecov
Copy link
codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (96ec4e5).
Report is 95 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5855     -254     
==========================================
- Hits         5322     5133     -189     
+ Misses        787      722      -65

see 110 files with indirect coverage changes

@marcalff marcalff changed the title Fix opentelemetry-collector bind address [TEST] Fix opentelemetry-collector bind address Jul 3, 2024
@marcalff marcalff marked this pull request as ready for review July 3, 2024 08:05
@marcalff marcalff requested a review from a team July 3, 2024 08:05
@marcalff marcalff added issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review labels Jul 3, 2024
@marcalff
Copy link
Member Author
marcalff commented Jul 3, 2024

See related:

esigo
esigo approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member
@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@marcalff marcalff merged commit f6dca99 into open-telemetry:main Jul 3, 2024
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jul 4, 2024
8C74 @malkia
Merge pull request #53 from open-telemetry/main
4767b95 
[TEST] Fix opentelemetry-collector bind address (open-telemetry#2989)
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Merged
@marcalff marcalff deleted the fix_collector_bind branch February 5, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esigo esigo esigo approved these changes

Assignees

No one assigned

Labels

issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcalff @esigo
0