10BC0 [DOC] Remove comment for unused LoggerProvider initialization params by herman5 · Pull Request #2972 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[DOC] Remove comment for unused LoggerProvider initialization params #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 1 commit into from
Jun 30, 2024
Merged

[DOC] Remove comment for unused LoggerProvider initialization params #2972

marcalff merged 1 commit into from
Jun 30, 2024

Conversation

@herman5
Copy link
Contributor
@herman5 herman5 commented Jun 30, 2024 •
edited
Loading

Changes

Removes @param comments for id_generator and sampler in the LoggerProvider constructor, which are not present in the constructor.

@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Jun 30, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@marcalff marcalff changed the title Remove unused LoggerProvider initialization params [DOC] Remove unused LoggerProvider initialization params Jun 30, 2024
@herman5 herman5 changed the title [DOC] Remove unused LoggerProvider initialization params [DOC] Remove comment for unused LoggerProvider initialization params Jun 30, 2024
@codecov
Copy link
codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (1e1f5c6).
Report is 93 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5855     -254     
==========================================
- Hits         5322     5133     -189     
+ Misses        787      722      -65

see 108 files with indirect coverage changes

@herman5 herman5 marked this pull request as ready for review June 30, 2024 21:27
@herman5 herman5 requested a review from a team June 30, 2024 21:27
@marcalff
Copy link
Member
marcalff commented Jun 30, 2024

@herman5 Thanks for the fix.

Related, in case you are interested in more contributions:

marcalff
marcalff approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 5e21b8a into open-telemetry:main Jun 30, 2024
@herman5 herman5 deleted the unused-params branch June 30, 2024 21:56
@malkia malkia mentioned this pull request Jul 1, 2024
Merged
3 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@herman5 @marcalff
0