E545 [CI] Enable ARM64 build in CI by esigo · Pull Request #2699 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[CI] Enable ARM64 build in CI #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2024
Merged

[CI] Enable ARM64 build in CI #2699

merged 9 commits into from
Jun 19, 2024

Conversation

esigo
Copy link
Member
@esigo esigo commented Jun 12, 2024

Fixes #1417 (issue)

Changes

Adds ARM CMake test to the CI.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov Codecov
Copy link
codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (fa1e9b0).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2699      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5853     -256     
==========================================
- Hits         5322     5131     -191     
+ Misses        787      722      -65

see 106 files with indirect coverage changes

lalitb
lalitb reviewed Jun 14, 2024
View reviewed changes
ThomsonTan
ThomsonTan reviewed Jun 14, 2024
View reviewed changes
@lalitb
Copy link
Member
lalitb commented Jun 14, 2024

We can also try using the Github ARM runner created for otel otel-linux-arm64 (refer - otel-linux-arm64

@esigo esigo marked this pull request as ready for review June 17, 2024 08:36
@esigo esigo requested a review from a team June 17, 2024 08:36
@esigo esigo changed the title [WIP] Enable ARM64 build in CI Enable ARM64 build in CI Jun 17, 2024
marcalff
marcalff reviewed Jun 17, 2024
View reviewed changes
marcalff
marcalff approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the CI.

@marcalff marcalff changed the title Enable ARM64 build in CI [CI] Enable ARM64 build in CI Jun 19, 2024
@marcalff marcalff merged commit aff26ac into open-telemetry:main Jun 19, 2024
@esigo esigo deleted the 1417-arm branch June 19, 2024 12:44
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable ARM64 build in CI

4 participants

@esigo @lalitb @ThomsonTan @marcalff
0