8000 [CI] Upgrade Maintainers CI to ubuntu-24.04 by marcalff · Pull Request #2670 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[CI] Upgrade Maintainers CI to ubuntu-24.04 #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2024
Merged

[CI] Upgrade Maintainers CI to ubuntu-24.04 #2670

merged 2 commits into from
May 16, 2024

Conversation

marcalff
Copy link
Member
@marcalff marcalff commented May 16, 2024 •
edited
Loading

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Upgraded maintainer CI from gcc-13 on ubuntu 22-04 to gcc-14 on ubuntu 24-04
  • Upgraded maintainer CI from clang-15 on ubuntu 22-04 to clang-18 on ubuntu 24-04
  • Disabled include-what-you-use (IWYU)
    • iwyu crashes on ubuntu 24-04, and testing under clang-18 is deemed more important
    • The CI integration for iwyu was incomplete, producing logs that are never inspected and fixed
    • More work is needed to integrate iwyu to produce a clean pass or fail (with logs) result, that can be enforced.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov Codecov
Copy link
codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (497eaf4) to head (b675b98).
Report is 61 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   87.12%   87.52%   +0.40%     
==========================================
  Files         200      188      -12     
  Lines        6109     5840     -269     
==========================================
- Hits         5322     5111     -211     
+ Misses        787      729      -58

see 55 files with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review May 16, 2024 13:17
@marcalff marcalff requested a review from a team May 16, 2024 13:17
@marcalff marcalff added the pr:please-review This PR is ready for review label May 16, 2024
lalitb
lalitb approved these changes May 16, 2024
View reviewed changes
Copy link
Member
@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

ThomsonTan
ThomsonTan reviewed May 16, 2024
View reviewed changes
@marcalff marcalff merged commit 4edcebd into open-telemetry:main May 16, 2024
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 16, 2024
@malkia
Merge pull request #34 from open-telemetry/main
08243ff 
[CI] Upgrade Maintainers CI to ubuntu-24.04 (open-telemetry#2670)
@marcalff marcalff mentioned this pull request May 16, 2024
Open
@marcalff marcalff deleted the fix_ci_maintainers branch June 3, 2024 21:05
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @ThomsonTan @lalitb
0